Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validator deploy tweaks #2784

Merged
merged 24 commits into from
Oct 16, 2023
Merged

validator deploy tweaks #2784

merged 24 commits into from
Oct 16, 2023

Conversation

aroralanuk
Copy link
Contributor

Description

  • fixes to deploy testnet4 for agents

Drive-by changes

  • truncating labels to length 63
  • adding .relayer to agentConfig.contextChainNames

Related issues

Backward compatibility

Yes

Testing

Manual

@aroralanuk
Copy link
Contributor Author

aroralanuk commented Oct 6, 2023

Some issues/comment:

  • added trunc to label (bc polygonzkevmtestnet exceeds the 63 character limit)
  • wasn't able to mount rpc urls for sepolia and scrollSepolia (only chains we spun the validator pods down for )
  • agentConfig isn't of being a string[] being a { relayer: string[], validator: string[], scraper: []} caused some deployment issues for helm (kathy, key funder)
  • the multiprotocolapp isn't setting the signers properly
  • multiprotocolapp needs a quote for gas value (added on evm)
  • good idea to have a --vm flag to skip deployments to specific vm only (otherwise need to comment a bunch of code)
  • helm commands run in serial now bc it was a lot of the chains to fail with the already known race condition
  • the setting context to hyperlane was causing issues in the announce-validator.ts which was expecting either context or chain name and s3 location
  • doesn't understand why the kathy script is only between fuji and solanadevnet
  • dry run errors out but wet run works fine for deploying validators (transaction already known)

rust/agents/validator/src/validator.rs Outdated Show resolved Hide resolved
rust/agents/validator/src/submit.rs Outdated Show resolved Hide resolved
rust/agents/validator/src/submit.rs Outdated Show resolved Hide resolved
Base automatically changed from testnet4-deploy to v3 October 10, 2023 19:10
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #2784 (f71e036) into v3 (a9e8b17) will decrease coverage by 0.24%.
The diff coverage is 0.00%.

❗ Current head f71e036 differs from pull request most recent head 45574f8. Consider uploading reports for the commit 45574f8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #2784      +/-   ##
==========================================
- Coverage   64.35%   64.12%   -0.24%     
==========================================
  Files          97       97              
  Lines         968      970       +2     
  Branches      101      101              
==========================================
- Hits          623      622       -1     
- Misses        308      310       +2     
- Partials       37       38       +1     
Components Coverage Δ
core 50.00% <ø> (ø)
hooks 67.93% <ø> (ø)
isms 67.91% <ø> (-0.75%) ⬇️
token 84.84% <ø> (ø)
middlewares 73.17% <ø> (ø)

@nambrot nambrot force-pushed the testnet4-agent-deployment branch from 81d9b1f to 8651e8d Compare October 10, 2023 20:52
@nambrot nambrot enabled auto-merge (squash) October 10, 2023 21:41
@nambrot nambrot merged commit 9168cca into v3 Oct 16, 2023
@nambrot nambrot deleted the testnet4-agent-deployment branch October 16, 2023 17:49
@yorhodes yorhodes mentioned this pull request Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants